AbsaOSS / ABRiS

Avro SerDe for Apache Spark structured APIs.
Apache License 2.0
230 stars 75 forks source link

FromAvroConfig class is not serializable #228

Closed yokhan-dukhin closed 3 years ago

yokhan-dukhin commented 3 years ago

I am using spark structured streaming with "foreach" sink. To get that work the class FromAvroConfig needs to be serializable. The fix should be simple, the class just needs to be extended from Serializable (tested locally, works fine).

cerveada commented 3 years ago

Yes, that makes sense. Adding Serializable should not break backward compatibility. It would be good to do the same thing for ToAvroConfig.

Since you already tested that it works, will you have a time to do a Pull Request for this?

yokhan-dukhin commented 3 years ago

Thanks, I just have created a PR #229. This is my 1st commit/PR in github, so please let me know if I did something wrong.