search

AbsaOSS / ABRiS

Avro SerDe for Apache Spark structured APIs.
Apache License 2.0
230 stars 75 forks source link

Abris #242 remove dependency on confluent naming strategy code #243

Closed cerveada closed 2 years ago

cerveada commented 2 years ago

fixes #242

kevinwallimann commented 2 years ago

The naming code should really never be changed. Otherwise, new schemas could be registered even if they already exist. Would it make sense to extract the part that should never be changed to a separate class?

cerveada commented 2 years ago

The naming code should really never be changed. Otherwise, new schemas could be registered even if they already exist. Would it make sense to extract the part that should never be changed to a separate class?

I don't think there is much else in the class. It's already the class main and only responsibility to create the subject name. So it does not make much sense to me to create another class.