AbsaOSS / ABRiS

Avro SerDe for Apache Spark structured APIs.
Apache License 2.0
231 stars 76 forks source link

abris #329 use pull_request_target to fix PRs from forks #334

Closed cerveada closed 1 year ago

cerveada commented 1 year ago

As I understand it, GitHub considers any fork PR as potentially dangerous. So when using on pull-request in action, it will always set all permissions to read.

There is pull_request_target that is less safe, but it should allow write permission.

So I am switching the action to pull_request_target and to mitigate the unsafeness I will also switch settings to Require approval for all outside collaborators.

There are other solutions to this that may be better, but also more complicated, if you want to look into it @miroslavpojer @Zejnilovic

For more info, see: