search

AbsaOSS / atum-service

Apache License 2.0
5 stars 1 forks source link

Initial solution of Integration tests control. #185

Closed miroslavpojer closed 3 months ago

miroslavpojer commented 4 months ago

Depends on #196

miroslavpojer commented 3 months ago

@miroslavpojer Please help me understand why there is testIT and testDB. Wouldn't testIT be enough?

Both commands represent a generic group of Integration tests so testIT is a generic name, sure. I will use it everywhere, where I do not have any reason to change - see reasons for testDB above.

salamonpavel commented 3 months ago

@miroslavpojer Please help me understand why there is testIT and testDB. Wouldn't testIT be enough?

* Both commands are solved in different ways. So a different name.

* Tests in database 'module' are testing db functions - so `testDB` looks ok.

* `testDB` is used on request of @benedeki - see comments above.

Both commands represent a generic group of Integration tests so testIT is a generic name, sure. I will use it everywhere, where I do not have any reason to change - see reasons for testDB above.

Thanks for explanation. I guess If we intend to follow a convention of having a "database" module in our projects for sql functions and their tests it's reasonable to have a dedicated command.

github-actions[bot] commented 3 months ago

JaCoCo agent module code coverage report - scala 2.13.11

Build Failed

github-actions[bot] commented 3 months ago

JaCoCo model module code coverage report - scala 2.13.11

Build Failed

github-actions[bot] commented 3 months ago

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 70.78% :x:

There is no coverage information present for the Files changed

benedeki commented 3 months ago

This item depends on: