Closed lsulak closed 2 months ago
This PR showcase high-quality code that adheres to best practices and coding standards. However, it would be beneficial to add automated tests for newly created endpoint. While manual testing via tools like Postman is useful for exploratory testing and very specific scenarios, it cannot replace automated tests.
Thanks, appreciate it!
Re API tests: actually it's a good idea. Ticket here: https://github.com/AbsaOSS/atum-service/issues/210 for the future as it's quite difficult to implement all the good ideas immediately :D
Release notes
api/v2/get-flow-checkpoints
for getting checkpoints (with measurements) of a flow; flow being identifiable based on an input partitioning (v2).This PR showcase high-quality code that adheres to best practices and coding standards. However, it would be beneficial to add automated tests for newly created endpoint. While manual testing via tools like Postman is useful for exploratory testing and very specific scenarios, it cannot replace automated tests.
Thanks, appreciate it!
Re API tests: actually it's a good idea. Ticket here: #210 for the future as it's quite difficult to implement all the good ideas immediately :D
There are also these unit tests for endpoints that could be implemented also for the new endpoint.
This PR showcase high-quality code that adheres to best practices and coding standards. However, it would be beneficial to add automated tests for newly created endpoint. While manual testing via tools like Postman is useful for exploratory testing and very specific scenarios, it cannot replace automated tests.
Thanks, appreciate it! Re API tests: actually it's a good idea. Ticket here: #210 for the future as it's quite difficult to implement all the good ideas immediately :D
There are also these unit tests for endpoints that could be implemented also for the new endpoint.
I personally don't like covering everything with all types of tests - but in this case I'll add them, perhaps it's a good enough balance to have at least 1 test for each endpoint type / service, and since here I introduced 'flow' service / functionality, it might be nice to have it.
Flow
Closes #188