AbsaOSS / atum-service

Apache License 2.0
5 stars 1 forks source link

#193: Drop support of Spark 2.4 #196

Closed benedeki closed 3 months ago

benedeki commented 3 months ago

Closes #193

github-actions[bot] commented 3 months ago

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 76.61% :green_apple:

There is no coverage information present for the Files changed

lsulak commented 3 months ago

The CI file, i.e. build instructions, must be also changed I assume, with the current setup.

Command sbt projects renders this

[info] agent_spark3 [info] agent_spark32_12 [info] * atum-service [info] database [info] model [info] model2_12 [info] server

I.e. there is no agent (one reason why CI is currently failing) and no suffix means scala 2.13 is used - otherwise, agent and model, defines 2.12 explicitly. Shouldn't we make it mode consistent? Something like

[info] agent_spark32_13 [info] agent_spark32_12 [info] * atum-service2_13 [info] database2_13 [info] model2_13 [info] model2_12 [info] server2_13

--

I think that 2.13 is default = ThisBuild / scalaVersion := Setup.scala213 // default version and thus is not explicitly used for the module names. I couldn't make it work yet (the explicit suffix)

benedeki commented 3 months ago

The CI file, i.e. build instructions, must be also changed I assume, with the current setup.

Command sbt projects renders this

[info] agent_spark3 [info] agent_spark32_12 [info] * atum-service [info] database [info] model [info] model2_12 [info] server

I.e. there is no agent (one reason why CI is currently failing) and no suffix means scala 2.13 is used - otherwise, agent and model, defines 2.12 explicitly. Shouldn't we make it mode consistent? Something like

[info] agent_spark32_13 [info] agent_spark32_12 [info] * atum-service2_13 [info] database2_13 [info] model2_13 [info] model2_12 [info] server2_13

--

I think that 2.13 is default = ThisBuild / scalaVersion := Setup.scala213 // default version and thus is not explicitly used for the module names. I couldn't make it work yet (the explicit suffix)

Yes, GitHub actions still need changes. I didn't want to hold this one back on that though. I am actually considering to make it a separate PR.