Closed benedeki closed 3 months ago
Overall Project | 76.61% | :green_apple: |
---|
There is no coverage information present for the Files changed
The CI file, i.e. build instructions, must be also changed I assume, with the current setup.
Command sbt projects
renders this
[info] agent_spark3 [info] agent_spark32_12 [info] * atum-service [info] database [info] model [info] model2_12 [info] server
I.e. there is no agent
(one reason why CI is currently failing) and no suffix means scala 2.13 is used - otherwise, agent and model, defines 2.12 explicitly. Shouldn't we make it mode consistent? Something like
[info] agent_spark32_13 [info] agent_spark32_12 [info] * atum-service2_13 [info] database2_13 [info] model2_13 [info] model2_12 [info] server2_13
❓
--
I think that 2.13 is default = ThisBuild / scalaVersion := Setup.scala213 // default version
and thus is not explicitly used for the module names. I couldn't make it work yet (the explicit suffix)
The CI file, i.e. build instructions, must be also changed I assume, with the current setup.
Command
sbt projects
renders this[info] agent_spark3 [info] agent_spark32_12 [info] * atum-service [info] database [info] model [info] model2_12 [info] server
I.e. there is no
agent
(one reason why CI is currently failing) and no suffix means scala 2.13 is used - otherwise, agent and model, defines 2.12 explicitly. Shouldn't we make it mode consistent? Something like[info] agent_spark32_13 [info] agent_spark32_12 [info] * atum-service2_13 [info] database2_13 [info] model2_13 [info] model2_12 [info] server2_13
❓
--
I think that 2.13 is default =
ThisBuild / scalaVersion := Setup.scala213 // default version
and thus is not explicitly used for the module names. I couldn't make it work yet (the explicit suffix)
Yes, GitHub actions still need changes. I didn't want to hold this one back on that though. I am actually considering to make it a separate PR.
project/Setup.scala
classCloses #193