AbsaOSS / atum-service

Apache License 2.0
5 stars 1 forks source link

response envelope #199

Closed salamonpavel closed 2 months ago

salamonpavel commented 3 months ago

Introduces envelopes for API responses. Closes #197

github-actions[bot] commented 3 months ago

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 73.3% -21.23% :green_apple:
Files changed 55.77% :x:


File Coverage
SuccessResponse.scala 100% -877.27% :x:
BaseController.scala 100% :green_apple:
PartitioningControllerImpl.scala 88.89% -11.11% :green_apple:
CheckpointControllerImpl.scala 76% -76% :x:
ErrorResponse.scala 69.39% -806.12% :x:
PlayJsonImplicits.scala 68.66% :green_apple:
github-actions[bot] commented 3 months ago

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 60.76% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] commented 3 months ago

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 86.35% -0.6% :green_apple:
Files changed 87.5% :green_apple:


File Coverage
HttpDispatcher.scala 47.44% -3.85% :green_apple:
lsulak commented 3 months ago

So probably the only thing now we have to do (after this PR, I'd say) is to make the agent compatible with v2 APIs. And also using circe for SerDe fully/everywhere, instead of the current approach.

salamonpavel commented 3 months ago

Release notes