#280: agent and server compatibility for Additional Data PATCH operation

lsulak commented 2 months ago

Note: Additional Data = AD

What was done:

a lot more than I wanted :( (but most files changed are a result of moving files from server/ to model/ - REST envelope classes)
AD update functionality compatible between Agent <-> Server
Changing HTTP Backend on Agent from HttpURLConnectionBackend -> OkHttpSyncBackend - inspired by https://github.com/softwaremill/sttp/issues/316 and https://github.com/raster-foundry/raster-foundry/pull/5306 because HttpURLConnectionBackend didn't support PATCH HTTP Method and we need it for AD update endpoint
Creating a general DTO Base 64 Encode function + tests
Moved Envelope related code from Server to Model, because Agent also needs it
Added E2E test using Balta to check the results - this is a new 'type' of test and will not be executed in CI yet. But if your local PG is ready & empty and the service is running locally, it will work with the proper service configuration
Removed a bunch of obsolete AD DTOs
Server supports these 2 endpoints: patchPartitioningAdditionalDataEndpointV2 and getPartitioningEndpointV2

Note: If you want to run AgentWithServerIntegrationTests then:

Prepare PG locally (make sure it has newest schemas / tables, and that it's empty)
Prepare Service - either as Dockerized one or a typical Localhost - and adjust src/test/resources/reference.conf accordingly - this is needed: atum.dispatcher.http.url="http://localhost:8080" and atum.dispatcher.type="http"
I personally run PG in Docker & Service in Docker and it all works very nicely

Closes #280

Release notes:

github-actions[bot] commented 2 months ago

Overall Project	59.69% `-12.4%`	:x:
Files changed	46.67%	:x:

File	Coverage
JsonSyntaxExtensions.scala	59.29% `-14.16%`	:x:

github-actions[bot] commented 2 months ago

Overall Project	78.49% `-18.64%`	:green_apple:
Files changed	39.06%	:x:

github-actions[bot] commented 2 months ago

Overall Project	100%	:green_apple:

There is no coverage information present for the Files changed

github-actions[bot] commented 2 months ago

Overall Project	68.87% `-1.42%`	:green_apple:
Files changed	79.83%	:x:

File	Coverage
PartitioningRepositoryImpl.scala	100%	:green_apple:
PartitioningServiceImpl.scala	100%	:green_apple:
FlowControllerImpl.scala	100%	:green_apple:
CheckpointControllerImpl.scala	100%	:green_apple:
PartitioningControllerImpl.scala	91.67%	:green_apple:
BaseController.scala	85.29%	:green_apple:
GetPartitioningAdditionalData.scala	56.41% `-49.74%`	:x:

lsulak commented 2 months ago

Release Notes:

AbsaOSS / atum-service