search

AbsaOSS / atum-service

Apache License 2.0
4 stars 1 forks source link

Can Additional data be modified? #80

Closed benedeki closed 4 months ago

benedeki commented 9 months ago

Question

Can additional data that already have a value (not NULL/Nonebe modified? If yes, they probably should have historization. If no, what happens if update is tried?

lsulak commented 9 months ago

Very good question, happy to talk about it on a call if needed.

But on the first glance it looks like additional data potentially can contain various things and maybe even some business logic can be applied to it, which might mean that having a history of it can bring some value, i.e. won't limit anybody (unlike no history, just raw updates).

So I would be inclined to say this: yes they can be modified, but using 'immutability' principle. A brand new record would be created, retiring an old one.

lsulak commented 9 months ago

We agreed on having updates and thus keeping a history of AdditionalData, but it's still open for further requirement/discussion.

lsulak commented 6 months ago

Implemented as part of #58 in #143