#11: Introduce code coverage measuring by JaCoCo

AbsaOSS / balta

Scala library to write Postgres DB code tests with

Apache License 2.0

3 stars 0 forks source link

#11: Introduce code coverage measuring by JaCoCo #12

Closed miroslavpojer closed 1 month ago

miroslavpojer commented 11 months ago

JaCoCo introduced into project.

Closes #11

lsulak commented 11 months ago

Oh wait a minute, this is almost an exact copy of https://github.com/AbsaOSS/balta/pull/10/files. I propose to repoint this PR to that branch then, not to master.

benedeki commented 11 months ago

Oh wait a minute, this is almost an exact copy of https://github.com/AbsaOSS/balta/pull/10/files. I propose to repoint this PR to that branch then, not to master.

Yeah, @miroslavpojer took my branch, added JaCoco support and created a PR. But directed it to master which I kind of missed. Therefore it's confusing.

miroslavpojer commented 11 months ago

Oh wait a minute, this is almost an exact copy of https://github.com/AbsaOSS/balta/pull/10/files. I propose to repoint this PR to that branch then, not to master.

Yeah, @miroslavpojer took my branch, added JaCoco support and created a PR. But directed it to master which I kind of missed. Therefore it's confusing.

Hi, sorry for that. I have repointed it to from master.

miroslavpojer commented 11 months ago

It would be good to document some usages / supported types etc into README, but otherwise really good work, I like the Either approach you chose, apart from many other things :)

Documented in README.md in commit f89709484446701ae85540a6b3a07ccdda696919,

miroslavpojer commented 11 months ago

Actually I noticed that the GH Pipeline definition for adding code coverage into PRs is missing.

LGTM otherwise

You are right, I will add it. @lsulak, @benedeki What do you prefer?

remove 2.12 from build.yml and call it in a separated jacoco.yml file?
call tests for 2.12 twice but in the second round with JaCoCo support?

I would follow the second option as depends on the job on build.yml. I have prepared it already.

github-actions[bot] commented 11 months ago

JaCoCo code coverage report - balta

File	Coverage [0%]	:x:
SetterFnc.scala	0%	:x:

Total Project Coverage	0%	:green_apple:

github-actions[bot] commented 1 month ago

JaCoCo 'balta' module code coverage report - scala 2.12.18

Overall Project	30.04%	:green_apple:

There is no coverage information present for the Files changed