search

AbsaOSS / enceladus

Dynamic Conformance Engine
Apache License 2.0
29 stars 14 forks source link

#2118 Remove Oozie from non-model modules #2124

Closed jakipatryk closed 1 year ago

jakipatryk commented 1 year ago

Removed Oozie and scheduling parts of code in all modules expect data-model.

Release notes suggestion

Menas: Scheduling tab has been removed. REST API: /oozie/isEnabled endpoint has been removed. REST API: Configuration properties referencing Oozie have been removed.

Closes #2118 Closes #2120

Zejnilovic commented 1 year ago

Do we still need cRonstrue? As far as I see, we can delete these.

jakipatryk commented 1 year ago

Do we still need cRonstrue? As far as I see, we can delete these.

@Zejnilovic yes seems it is not needed; removed

benedeki commented 1 year ago

If tests are passing, that's probably good enough for know. And the complete functionality will be checked with whole Enceladus 3 test(s). Adding 'PR: no testing needed` label.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jakipatryk commented 1 year ago

Could you please:

  • fix the filename of data-model/src/main/scala/za/co/absa/enceladus/model/menas/scheduler/oozie/OozIeSchedule.scala
  • Comment both remaining Oozie classes (OozieSchedule, OozieScheduleInstance), that they are kept for data model compatibility reason and to avoid the need of data migration.

@benedeki Done