AbsaOSS / enceladus

Dynamic Conformance Engine
Apache License 2.0
29 stars 14 forks source link

#2131 Remove CSRF token and JWT in cookies #2142

Closed jakipatryk closed 1 year ago

jakipatryk commented 1 year ago

Closes #2131 Closes #2130

Zejnilovic commented 1 year ago

FYI @miroslavpojer, this would, in postman, remove the need to use CSRF tokens in API calls.

miroslavpojer commented 1 year ago

FYI @miroslavpojer, this would, in postman, remove the need to use CSRF tokens in API calls.

I can confirm theat create Dataset (POST) and edit Dataset (PUT) endpoint calls are working without CSRF token present. I can update postman collection and commit new version in this branch.

miroslavpojer commented 1 year ago

FYI @miroslavpojer, this would, in postman, remove the need to use CSRF tokens in API calls.

I can confirm theat create Dataset (POST) and edit Dataset (PUT) endpoint calls are working without CSRF token present. I can update postman collection and commit new version in this branch.

CSRF tokens removed from Postman solution in commit - 3e5d1196681c1bbe2ed5a7a85cccb24febf5c98f.

jakipatryk commented 1 year ago

Also, have you looked into XSS protection?

Not really. One way to ensure XSS protection would be to use Angular (it is quite hard to be XSS-vulnerable with Angular as it sanitises everything by default).

benedeki commented 1 year ago

Because run both by @Zejnilovic and @miroslavpojer I've added the PR: Tested label.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication