Closed dk1844 closed 1 year ago
During review of API end point I have identified this end-point "/api/mappingTable/updateDefaults ==> updateDefaults" where required parameter is named "upd". I would propose rename it to "updateDefault"
- [x] code reviewed
- [x] pulled
- [x] built - all tests
- [x] check of API end points
During review of API end point I have identified this end-point "/api/mappingTable/updateDefaults ==> updateDefaults" where required parameter is named "upd". I would propose rename it to "updateDefault"
Fixing docs is fine, but I am against updating the deprecated v2 API.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Fixing docs is fine, but I am against updating the deprecated v2 API.
Here, it makes no difference in compatibility, because it is the name of the "body" (in HTTP, this is not named anyway). Normally, I would agree with @Zejnilovic that changing old API is rather unwanted, here, we can afford it.
It should actually only fix the doc AFAIK.
This PR aims to solve issue #2132.
A few Swagger-documentation issues has been fixed, specifically:
V2 API
/edit
multiendpoint/edit
and/edit/{searchQuery}
together, which resulted in incorrect requiredsearchQuery
param on/edit
. Divided into two, now behaves correctlyUnwanted
@AuthenticationPrincipal
fields were present@AuthenticationPrincipal UserDetails
API parameter introduced unwantedaccountNonExpired
,accountNonLocked
,credentialsNonExpired
,authorities[0].authority
fields in Swagger. Anignore
has been added for this parameter.Closes #2132