AbsaOSS / enceladus

Dynamic Conformance Engine
Apache License 2.0
30 stars 14 forks source link

#2159: adding Run Number into Standardization spark job #2171

Closed lsulak closed 1 year ago

lsulak commented 1 year ago

Draft for now, I need to test a few things first & think about whether it should be part of Common Job Execution or only in the standardization.

Update: tests passed and it works as expected in the Menas UI & INFO file & Mongo DB.

--

I can see how the standardization and conformance are logically intertwined. The current implementation should generally work but there might be a case where Run Number is not present at all in the INFO file - if Conformation Job runs separately against dataset that has INFO file produced by Standardization Job that didn't produce the Run Number (because it is older than the one in this PR).

Q: Should the Run Number represent any standardization or conformance or combined job that ran against a dataset? If yes, then the current implementation is too naive and I'll add some check into the conformation job - something like: if the Run Number is not present in INFO file, add it.

lsulak commented 1 year ago

I also changed the implementation of the sorting of Additional Info data in Menas, it's now sorted by ascending order.

Before:

Screenshot 2023-02-13 at 11 18 38

After:

Screenshot 2023-02-13 at 11 18 42
benedeki commented 1 year ago

Q: Should the Run Number represent any standardization or conformance or combined job that ran against a dataset? If yes, then the current implementation is too naive and I'll add some check into the conformation job - something like: if the Run Number is not present in INFO file, add it.

I think it's good as it is now. No need to complicate it further.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication