AbsaOSS / enceladus

Dynamic Conformance Engine
Apache License 2.0
29 stars 14 forks source link

#2151 Remove hardcoded spline from Enceladus #2176

Closed Zejnilovic closed 1 year ago

Zejnilovic commented 1 year ago

Fixes #2152

Release Notes: Remove HardCoded spline. Add options to bash scripts to run spline codeless.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

miroslavpojer commented 1 year ago
Zejnilovic commented 1 year ago

Looks good. Could SplineReference be removed too?

It could. But the Spline reference has nothing to do with Spline. It is just the destination folder and app id. That is still good info.

On the other hand, if I start toying with it, I would also have to look into MongoDB migration.

I would touch on the data model with move PostgreSQL, not now.

What do you think?

benedeki commented 1 year ago

Looks good. Could SplineReference be removed too?

It could. But the Spline reference has nothing to do with Spline. It is just the destination folder and app id. That is still good info.

On the other hand, if I start toying with it, I would also have to look into MongoDB migration.

I would touch on the data model with move PostgreSQL, not now.

What do you think?

Fair enough 👍