Open TebaleloS opened 1 year ago
I have tested both the sh
and cmd
script to see that they correctly pass the datetime configuration fields down to the spark-submit
. I have not run the actual job.
sh
./run_standardization.sh ... --parquet-datetime-read-mode XX --parquet-datetime-write-mode YY
-> spark-submit ... --conf spark.sql.parquet.datetimeRebaseModeInRead=XX --conf spark.sql.parquet.datetimeRebaseModeInWrite=YY --conf spark.sql.parquet.int96RebaseModeInRead=XX --conf spark.sql.parquet.int96RebaseModeInWrite=YY ...
✔️
./run_conformance.sh ... --parquet-datetime-read-mode XX --parquet-datetime-write-mode YY
-> spark-submit ... --conf spark.sql.parquet.datetimeRebaseModeInRead=XX --conf spark.sql.parquet.datetimeRebaseModeInWrite=YY --conf spark.sql.parquet.int96RebaseModeInRead=XX --conf spark.sql.parquet.int96RebaseModeInWrite=YY ...
✔️
./run_standardization_conformance.sh ... --parquet-datetime-read-mode XX --parquet-datetime-write-mode YY
-> spark-submit ... --conf spark.sql.parquet.datetimeRebaseModeInRead=XX --conf spark.sql.parquet.datetimeRebaseModeInWrite=YY --conf spark.sql.parquet.int96RebaseModeInRead=XX --conf spark.sql.parquet.int96RebaseModeInWrite=YY ...
✔️
cmd
.\run_standardization.cmd ... --parquet-datetime-read-mode XX --parquet-datetime-write-mode YY
->
spark-submit ... --conf spark.sql.parquet.datetimeRebaseModeInRead=XX --conf spark.sql.parquet.datetimeRebaseModeInWrite=YY --conf spark.sql.parquet.int96RebaseModeInRead=XX --conf spark.sql.parquet.int96RebaseModeInWrite=YY ...
✔️
.\run_conformance.cmd ... --parquet-datetime-read-mode XX --parquet-datetime-write-mode YY
->
spark-submit --conf spark.sql.parquet.datetimeRebaseModeInRead=XX --conf spark.sql.parquet.datetimeRebaseModeInWrite=YY --conf spark.sql.parquet.int96RebaseModeInRead=XX --conf spark.sql.parquet.int96RebaseModeInWrite=YY
✔️
.\run_standardization_conformance.cmd ... --parquet-datetime-read-mode XX --parquet-datetime-write-mode YY
-> spark-submit" ... --conf spark.sql.parquet.datetimeRebaseModeInRead=XX --conf spark.sql.parquet.datetimeRebaseModeInWrite=YY --conf spark.sql.parquet.int96RebaseModeInRead=XX --conf spark.sql.parquet.int96RebaseModeInWrite=YY ...
✔️
Kudos, SonarCloud Quality Gate passed!
Notes
DEFAULT_PARQUET_DATETIME_READ_MODE
andDEFAULT_PARQUET_DATETIME_WRITE_MODE
with a default valueCORRECTED
.datetime read/write mode
Closes #2175