AbsaOSS / enceladus

Dynamic Conformance Engine
Apache License 2.0
29 stars 14 forks source link

s3a Wrapper script null-value behaviour #2210

Closed MatloaItumeleng closed 4 months ago

MatloaItumeleng commented 5 months ago

Describe the bug

S3a wrapper script does not work with --null-value when passed as --null-value ' '

To Reproduce

Steps /commands to run to reproduce the behavior:

/<Wrapper_script_path>/s3a_wrapper.sh /<helper_script_path>/run_standardization.sh --deploy-mode cluster --dataset-name Custom_datasetName --menas-auth-keytab /<user_cred_file_path>/user_authFile.krb --dataset-version 1 --report-date 2024-02-07 --report-version 1 --raw-format csv --charset cp1252 --header false --delimiter U+00A6 --null-value '        '

Expected behavior

s3a_wrapper script should not throw a warning for the given inputs parameters similarly when helper script is used individually as seen on screenshot provided below

Screenshots

image compared against warning when using null-value ' ' on s3a wrapper script image

Desktop (please complete the following information):

dk1844 commented 5 months ago

I will let @MatloaItumeleng know about this fix