AbsaOSS / fa-db

Functional Access to Database
Apache License 2.0
3 stars 0 forks source link

Feature/doobie with status #106

Closed salamonpavel closed 11 months ago

salamonpavel commented 1 year ago

In this PR, the below listed issues have been addressed:

I am aware that this pull request contains a substantial number of changes. I understand that this can make the review process more challenging and time-consuming, and I appreciate your efforts in ensuring our codebase maintains its high quality.

I am fully aware that the volume of changes may be overwhelming, and it's important to me that everyone on the team feels comfortable with these updates. To that end, I am more than willing to walk anyone through the code changes, explain the reasoning behind each modification, and answer any questions you may have.

Please feel free to reach out to me at your convenience if you would like a walkthrough of the code or if you have any questions or concerns.

Please review the changes and provide your feedback.

Closes #11 Closes #51 Closes #99 Closes #104 Closes #105

github-actions[bot] commented 1 year ago

JaCoCo code coverage report - scala 2.12.17

Total Project Coverage 61.79% :green_apple:
File Coverage [61.79%]
NamingConvention.scala 100% :green_apple:
FunctionStatusWithData.scala 100% :green_apple:
StandardStatusHandling.scala 100% :green_apple:
FunctionStatus.scala 100% :green_apple:
NamingException.scala 100% :green_apple:
StatusException.scala 100% :green_apple:
DBFunctionFabric.scala 97.59% :green_apple:
DBSchema.scala 93.88% :green_apple:
ExplicitNamingRequired.scala 87.5% :green_apple:
LettersCase.scala 85.29% :green_apple:
SnakeCaseNaming.scala 84.29% :green_apple:
AsIsNaming.scala 40.63% :x:
DBEngine.scala 20% :x:
DBFunction.scala 6.83% :x:
Query.scala 0% :x:
UserDefinedStatusHandling.scala 0% :x:
lsulak commented 11 months ago

File /home/runner/work/fa-db/fa-db/examples/src/main/scala/za/co/absa/fadb/examples/enceladus/DatasetSchema.scala still doesn't have licence header according to the CI

lsulak commented 11 months ago

Jacoco doesn't seem to work here, can you take a look @miroslavpojer please? Perhaps this is something you encountered before

salamonpavel commented 11 months ago

File /home/runner/work/fa-db/fa-db/examples/src/main/scala/za/co/absa/fadb/examples/enceladus/DatasetSchema.scala still doesn't have licence header according to the CI

Seems that the license formatting was off. The license check passes now.

github-actions[bot] commented 11 months ago

JaCoCo code coverage report - scala 2.13.12

Total Project Coverage 63.49% :green_apple:
File Coverage [63.49%]
LettersCase.scala 100% :green_apple:
ExplicitNamingRequired.scala 100% :green_apple:
NamingConvention.scala 100% :green_apple:
FunctionStatusWithData.scala 100% :green_apple:
StandardStatusHandling.scala 100% :green_apple:
FunctionStatus.scala 100% :green_apple:
NamingException.scala 100% :green_apple:
StatusException.scala 100% :green_apple:
DBFunctionFabric.scala 97.59% :green_apple:
DBSchema.scala 93.88% :green_apple:
SnakeCaseNaming.scala 89.29% :green_apple:
AsIsNaming.scala 72.22% :x:
DBEngine.scala 20% :x:
DBFunction.scala 7.11% :x:
Query.scala 0% :x:
UserDefinedStatusHandling.scala 0% :x: