Open salamonpavel opened 11 months ago
Total Project Coverage | 58.19% | :green_apple: |
---|
Module | Coverage | |
---|---|---|
fa-db:core Jacoco Report - scala:2.12.17 | 61.79% | :x: |
fa-db:streaming Jacoco Report - scala:2.12.17 | 0% | :x: |
Total Project Coverage | 59.46% | :green_apple: |
---|
Module | Coverage | |
---|---|---|
fa-db:core Jacoco Report - scala:2.13.12 | 63.49% | :x: |
fa-db:streaming Jacoco Report - scala:2.13.12 | 0% | :x: |
Found a few tiny things and Jacoco coverage action is still failing (not on insufficient coverage though), so please take a look. Otherwise LGTM.
I pulled it, reviewed, compiled and ran tests.
Fixed this. The problem was in node version of Github's updated runner. Solved by an update of the jacoco github action version.
@lsulak @jakipatryk Thanks for the initial review here and on the calls we had yesterday. Based on your comments I have made the streaming part for Slick as a separate package since additional dependencies are needed and we don't want to be importing transitive dependencies into our projects when streaming is not used. At the moment there is core module for non-streaming, streaming module for streaming, slick module for slick non-streaming, slick-streaming module for slick streaming and doobie module. Doobie module provides both non-streaming and streaming functions since Doobie already bring all the dependencis needed (works with fs2 streams under the hood) so there would be no benefit in splitting this into separate modules.
Added support for streaming for both Slick and Doobie. Since Slick works with Futures but for streaming it relies on IOs or other effect types there was a need to abstract the streaming operation in a new DBStreamingEngine.
There are following modules:
Closes #107