search

AbsaOSS / login-service

AbsaOSS Common Login gateway using JWT Public key signatures
Apache License 2.0
2 stars 0 forks source link

Feature/36 externalizing config #37

Closed dk1844 closed 1 year ago

dk1844 commented 1 year ago

This PR bring some updates forcing the user to provide their own application.yaml config. All is described in the README update.

For the simplest test-run, you can either just copy&rename example.application.yaml -> application.yaml and it will be picked up by default. Other options in the readme and at Spring boot - Externalized Configuration.

Closes #36.

TheLydonKing commented 1 year ago

Info and Health endpoint tests seem to be failing. Seems to be failing due to config according to the logs.

github-actions[bot] commented 1 year ago

JaCoCo code coverage report - scala:2.12.17

There is no coverage information present for the Files changed

Total Project Coverage 75.6% :green_apple:
dk1844 commented 1 year ago

Info and Health endpoint tests seem to be failing. Seems to be failing due to config according to the logs.

Thanks, thanks for noticing before I did. Yes, that test relies on an application config being present - so I have added one for tests only.