AbsaOSS / login-service

AbsaOSS Common Login gateway using JWT Public key signatures
Apache License 2.0
2 stars 0 forks source link

#60 displayname added to JWT #61

Closed dk1844 closed 10 months ago

dk1844 commented 10 months ago

The user token now optionally contains field displayname for a friendly name string. This either comes from LDAP's displayname field or from user config (also displayname field).

Some unit tests added/adjusted.

FYI @fateeand

Example - config-based:

With config of

            - username: "TestUser"
              password: "password123"
              displayname: "Test User MD"
              email: "test@abs.com"
              groups:
                - "groupA"
                - "groupB"

the token contains this information:

{
  "sub": "TestUser",
  "exp": 1692365356,
  "iat": 1692350956,
  "groups": [
    "groupA",
    "groupB"
  ],
  "email": "test@abs.com",
  "displayname": "Test User MD"
}

Example - LDAP-based:

.. tested against company LDAP


{
  ...,
  "displayname": "Daniel Kavan (CZ)"
}
github-actions[bot] commented 10 months ago

JaCoCo code coverage report - scala:2.12.17

File Coverage [58.07%] :x:
OptionExt.scala 100% :green_apple:
User.scala 100% :green_apple:
JWTService.scala 83.51% :green_apple:
ConfigUsersAuthenticationProvider.scala 74.19% :x:
UsersConfig.scala 71.92% :x:
ActiveDirectoryLDAPAuthenticationProvider.scala 18.6% :x:
Total Project Coverage 74.87% :green_apple: