search

AbsaOSS / login-service

AbsaOSS Common Login gateway using JWT Public key signatures
Apache License 2.0
2 stars 0 forks source link

#86 make ldap fields mapping used configurable #97

Closed TheLydonKing closed 5 months ago

TheLydonKing commented 5 months ago

Added a configurable field to add additional fields to the JWT claims and to retrieve more information from Ldap.

Please let me know if this implementation makes sense.

Closes #86

github-actions[bot] commented 5 months ago

JaCoCo code coverage report - scala:2.12.17

File Coverage [70.99%] :x:
ActiveDirectoryLDAPConfig.scala 100% :green_apple:
User.scala 100% :green_apple:
JWTService.scala 87.35% :green_apple:
ConfigProvider.scala 79.55% :x:
ConfigUsersAuthenticationProvider.scala 74.19% :x:
UsersConfig.scala 73.38% :x:
ActiveDirectoryLDAPAuthenticationProvider.scala 18.55% :x:
Total Project Coverage 74.73% :green_apple:
TheLydonKing commented 5 months ago

Using Map[String, Option[AnyRef]] for the new field may be a bit overkill but logically it makes sense to me.

Let me know if you disagree or have a better solution.