search

AbsaOSS / rn-indy-sdk

This code was starting point of https://github.com/hyperledger/indy-sdk-react-native where the work continues.
Apache License 2.0
11 stars 6 forks source link

Explicitly disable access to UI thread and set Swift version in podspec #27

Closed jakubkoci closed 4 years ago

jakubkoci commented 4 years ago

Fixes #23

TimoGlastra commented 4 years ago

@jakubkoci I think you also need to set it in obj-c side. As the docs mention that that will remove the warning: Otherwise you will see a warning that in the future your module may be initialized on a background thread unless you explicitly opt out with + requiresMainQueueSetup:

+ (BOOL)requiresMainQueueSetup
{
  return NO;
}

https://reactnative.dev/docs/native-modules-ios#implementing--requiresmainqueuesetup

jakubkoci commented 4 years ago

@TimoGlastra I've just tried that and it works - doesn't show a warning. And yes, I've finally run the app on iOS :) I tried to put that into *.m file but there is just an interface and compiler complaint there shouldn't be an implementation 🤷‍♂️

TimoGlastra commented 4 years ago

Then I'll rest my case :)