AbsaOSS / spark-commons

Apache License 2.0
7 stars 0 forks source link

#78: Move ErrorMessage type from spark data standardization into spar… #79

Closed TebaleloS closed 1 year ago

TebaleloS commented 1 year ago

…k commons

Closes #78

TebaleloS commented 1 year ago

LGTM (just read the code). Not entirely sure about formatting of the case class params (I would put the first field on the line with the case class name, but I can see that this formatting is used elsewhere in the project, so let's keep it as-is for now).

@TebaleloS, maybe, when/if you also get to implement this change from the standardization perspective, please link this issue/PR for reference.