search

AbsaOSS / spline-getting-started

Apache License 2.0
24 stars 17 forks source link

Improve docker compose #2

Closed wajda closed 3 years ago

wajda commented 4 years ago

Originally posted by @DaimonPl in https://github.com/AbsaOSS/spline/pull/693#issue-427673433

I had several problems with original compose:

spline was not actively waiting for arangodb - because of that spline initialization failed in random way spline was not performing check if db is already initialized - because of that it was not possible to run it more than once unless previous instances were removed or compose.yml modified arangodb was not exposed on localhost to access its ui

here are the changes:

  • arangodb now exposes port
  • spline is actively waiting for arangodb before start (using simple curl)
  • spline is performing db initialization only if marker file does not exist
DaimonPl commented 4 years ago

I think this can be closed, PR is merged

omennemo commented 4 years ago

The docker-compose that is in the guide on GH pages is not the same as the updated one. The documentation probably needs an update as well