AbsaOSS / spline-spark-agent

Spline agent for Apache Spark
https://absaoss.github.io/spline/
Apache License 2.0
183 stars 93 forks source link

Adding feature to include token generation for long process of spark. #618

Closed rupesh3020 closed 1 year ago

rupesh3020 commented 1 year ago

As we have feature to add HTTP headers in the header configuration but this token expires in one hour and spline does not have a mechanism to recreate token and make requests.

This feature adds the functionality by adding a new configuration authentication, where we can specify

cerveada commented 1 year ago

Is this implementing Bearer authentification? (https://datatracker.ietf.org/doc/html/rfc6750)

I think it would make sense to have authentification.type property to allow other types in the future.

cerveada commented 1 year ago

Currently, the build is failing because test do not compile. The tests must be modified to accommodate the changes in the dispatcher.

rupesh3020 commented 1 year ago

Currently, the build is failing because test do not compile. The tests must be modified to accommodate the changes in the dispatcher.

@cerveada Tests are fixed and i have tested the jar, it works fine. can you please check

cerveada commented 1 year ago

@rupesh3020 thanks for fixing the tests and other issues, I will take a look.

rupesh3020 commented 1 year ago

@cerveada Issues fixed. Can you please check once. I have done functional testing

wajda commented 1 year ago

Sorry guys, I was really buried with other stuff recently, but I really would like to have a quick look it it. Give me an hour or two, I'll check it out. In general, yes, that's awesome feature, I'm not going to delay merge.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

wajda commented 1 year ago

@rupesh3020 Thank you very much for your contribution!. We've made a few changes to your code and merged it as another pull request - #631. So I'm closing this one for that reason.