search

AbsaOSS / spline-spark-agent

Spline agent for Apache Spark
https://absaoss.github.io/spline/
Apache License 2.0
183 stars 93 forks source link

pr/618 #631

Closed wajda closed 1 year ago

wajda commented 1 year ago

This is a formatted and slightly refactored version of the PR #618 by @rupesh3020

Excepts for some minor code formatting the changes I made are concentrated in the AuthenticationFactory.scala file:

  1. Renamed AuthenticationFactory.scala to authentication.scala according to the Scala style guide for files that contain more classes.
  2. Replaced deprecated Scala JSON parser with the agent internal HarversterJsonSerDe and simplified the connected code.
  3. Replaced unnecessary case classes with objects and normal classes.
  4. Encapsulated all interactions with the mutable variable tokenCache in one method for clarity.
  5. Made the rest of the code more concise and self-describing.
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication