search

AbsaOSS / spline-spark-agent

Spline agent for Apache Spark
https://absaoss.github.io/spline/
Apache License 2.0
176 stars 92 forks source link

Use external jar for shading json4s #667

Closed cerveada closed 1 year ago

cerveada commented 1 year ago

Current solution of shaded json4s classes in project makes testing and debugging difficult. To solve this, shaded json4s will be moved to external jar/library.

cerveada commented 1 year ago

Maven Shade Plugin is having issues shading Scala classes https://stackoverflow.com/questions/55309684/does-maven-shade-plugin-work-with-scala-classes https://issues.apache.org/jira/browse/MSHADE-345

cerveada commented 1 year ago

http://eed3si9n.com/jarjar-abrams/

cerveada commented 1 year ago

This issue: https://github.com/eed3si9n/jarjar-abrams/issues/32 is causing an exception when instantiating shaded org.json4s.DefaultFormats

wajda commented 1 year ago

Closing this in favour of #675