AbsaOSS / spline-spark-agent

Spline agent for Apache Spark
https://absaoss.github.io/spline/
Apache License 2.0
175 stars 90 forks source link

issue #757 Initialization failure handling control #758

Open wajda opened 8 months ago

wajda commented 8 months ago

fixes #757

Adds a new config property:

spline.onInitFailure = LOG | BREAK
sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-actions[bot] commented 8 months ago

JaCoCo code coverage report

File Coverage [40.56%] :x:
AgentConfig.scala 84.38% :green_apple:
AgentBOM.scala 72.85% :x:
InitFailureHandlingMode.java 0% :x:
SparkLineageInitializer.scala 0% :x:
Total Project Coverage 42.08% :green_apple:
cerveada commented 8 months ago

As I understand it there are three places from which agent code is run:

Spark listener is wrapped in try catch, so we can't influence what is happening outside of that. For both init methods are you sure there is no catch block that will make this config unusable?

cerveada commented 8 months ago

Can we have tests for this?