AbsaOSS / spline-spark-agent

Spline agent for Apache Spark
https://absaoss.github.io/spline/
Apache License 2.0
185 stars 95 forks source link

New spline.pluginsEnabledByDefault property #759

Open martinf-moodys opened 1 year ago

martinf-moodys commented 1 year ago

This new property aims to fix a performance issue when scanning plugins via ClassGraph during Spline initialization. This may take up to 30 seconds to call ClassGraph.scan from AutoDiscoveryPluginRegistry. By default, the property is set to true to keep the current behavior.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

wajda commented 4 months ago

I somehow missed this PR, sorry. That's a good idea, but it contains a couple of things I'm not sure about. Let me review the PR thoroughly.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud