AbsaOSS / spline

Data Lineage Tracking And Visualization Solution
https://absaoss.github.io/spline/
Apache License 2.0
599 stars 154 forks source link

spline #1131 Re-implement SPLINE::IS_VISIBLE_FROM_TX() function to pu… #1132

Closed wajda closed 1 year ago

wajda commented 1 year ago

…re AQL

fixes #1131

  1. Replace the SPLINE::IS_VISIBLE_FROM_TX() user defined function with inline AQL expressions

The PR is still WIP because of missing unit tests. The included in the PR aql-gen-helper.spec.ignore.ts test requires mocks for @arangodb module, particularly the aql string interpolator that is used for AQL code generation. I need to figure out how to either mock it properly, or use a real embedded database instance to run tests again.

wajda commented 1 year ago

@korel-san , any idea how to solve the unit test issue better?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication