search

AbsaOSS / spline

Data Lineage Tracking And Visualization Solution
https://absaoss.github.io/spline/
Apache License 2.0
599 stars 154 forks source link

Label filter still not working #1158

Closed wajda closed 1 year ago

wajda commented 1 year ago

There was a bug fix before - #1122. Not sure if it's related though. There's no error message now, but the result is always empty.

wajda commented 1 year ago

fyi @korel-san

wajda commented 1 year ago

The issue was caused by the misalignment between the Producer API and Consumer API assumptions regarding the way how to index and query the execution plan labels from the end of the associated events. The older agent simply copied the execution plan labels to the event object before sending it to the server, while the Consumer query only looked at the given entity and didn't take the relation (edge) into account. At some point the agent changed the behavior and started relying on the server to merge the labels on either indexing on query time, which has not been implemented. So the fix would be to add missing progress -> executionPlan relation treatment. I guess the simplest solution would be to include execution plan labels into the ExecPlanDetails and index them in the progress_view as a separate field. Then the search query would simply do logical OR in the label predicate.