Closed benedeki closed 7 months ago
File | Coverage [31.26%] | :x: |
---|---|---|
DBTableColumn.scala | 100% | :green_apple: |
ResourceReader.scala | 100% | :green_apple: |
PgTableFileParser.scala | 90.6% | :green_apple: |
DBTableIndex.scala | 43.51% | :x: |
package.scala | 38% | :x: |
DBTable.scala | 25.34% | :x: |
TableColumnAdd.scala | 0% | :x: |
TablePrimaryKeyAdd.scala | 0% | :x: |
TablePrimaryKeyDrop.scala | 0% | :x: |
TableIndexCreate.scala | 0% | :x: |
DBTableFromPG.scala | 0% | :x: |
TableCreation.scala | 0% | :x: |
Total Project Coverage | 22.68% | :green_apple: |
---|
File | Coverage [31.26%] | :x: |
---|---|---|
DBTableColumn.scala | 100% | :green_apple: |
ResourceReader.scala | 100% | :green_apple: |
PgTableFileParser.scala | 90.6% | :green_apple: |
DBTableIndex.scala | 43.51% | :x: |
package.scala | 38% | :x: |
DBTable.scala | 25.34% | :x: |
TableColumnAdd.scala | 0% | :x: |
TablePrimaryKeyAdd.scala | 0% | :x: |
TablePrimaryKeyDrop.scala | 0% | :x: |
TableIndexCreate.scala | 0% | :x: |
DBTableFromPG.scala | 0% | :x: |
TableCreation.scala | 0% | :x: |
Total Project Coverage | 22.68% | :green_apple: |
---|
The application already seems to be packed with a lot of functionality, which is fantastic! I've taken a look at the changes you've made and left a few comments. None of them are critical, but I believe they could enhance your code, so please consider them when you have a moment.
I wish I could provide more detailed feedback on the code itself. However, I'll need to familiarize myself with the overall application first. Unfortunately, the current state of the project lacks a README file with documentation, and there are no comments within the code. Additionally, the lack of tests makes it challenging to understand the expected behavior of the code. These factors make collaboration a bit difficult.
I strongly recommend adding a comprehensive README and comments in your code to provide context and make it easier for others (and future you) to understand. Also, consider adding tests to ensure your code behaves as expected and to prevent potential bugs from being introduced in the future. Keep up the good work!
Adds the ability to read table definition, its fields and indexes from PG system tables. Some renames and classes placement changes.
NB! Not tested for full functionality. That will come after further changes.
Closes #13 Fixes #4