AbsolemJackdaw / AppleCrates

sell your items out of crates
GNU General Public License v3.0
2 stars 6 forks source link

Add rendering of multiple items depending on fullness #10

Closed williambl closed 1 year ago

williambl commented 1 year ago

Motivation

See #9.

Content

Currently, this PR makes crates render up to 9 items in rows of 3, depending on its fullness. One rendered item is equivalent to one selling stack, so if a crate sells 10 apples, then it will need to be full of 90 apples to look completely full.

It also adds a config, with the option to switch between new and old style rendering.

williambl commented 1 year ago

all ready now :)

AbsolemJackdaw commented 1 year ago

I believe this fork has been created from an outdated branch. 1.19 is a couple versions behind. either use 1.19.2 or hopper_support please ! hopper_support is the latest version that still has to be merged into 1.19.2

This PR could also use a hook in the resource reload manager to reevaluate the config file . I tested changing the value when the game was running but that didn't seem to work. (with rebuild and F3+T) Does it work on your end ?

williambl commented 1 year ago

whoops, I'll rebase it once I'm home :)

as for the config, I'm not really familiar with forge's config system - I just followed what the community wiki said :P sure, I'll add a resource reload listener if that's needed though :)

williambl commented 1 year ago

rebased onto 1.19.2.