search

AbsolemJackdaw / Paintings--

GNU General Public License v3.0
14 stars 12 forks source link

Animated paintings show up squashed in GUI #58

Closed Skeithh closed 2 years ago

Skeithh commented 2 years ago

There's a tiny issue that when you have an animated painting (which will have a larger image for the frames), it shows up kind of funky and squashed in the GUI. If its possible for the GUI to maybe be set up so that it only takes the first frame of the painting, that'd be great.

example: image

AbsolemJackdaw commented 2 years ago

aren't animated paintings an optifine thing ?

Skeithh commented 2 years ago

nope! they are possible in vanilla. All you need is an .mcmeta file to tell it to be animated

AbsolemJackdaw commented 2 years ago

okay, ill see what i can do. may take a while, exams are around the corner.

Skeithh commented 2 years ago

No worries, its not an urgent thing now that I know what im supposed to look for to find my animated paintings. if it helps- the way that the animation mcmeta file looks like is more or less what i attached here. image

ideally it could just look at frame 0 (if the "frames" field is present) and otherwise display the squashed image.

AbsolemJackdaw commented 2 years ago

image

i managed to find a way. there will be a new possible option to put in painting data in the json file anim will now serve to tell how long the animation file is, x and y what the size of the visible painting should be. the animation will not be handled by the gui, but should then be handled in-world by minecraft itself.

i hope this pleases you :D