AbsolemJackdaw / Paintings--

GNU General Public License v3.0
14 stars 12 forks source link

[1.19.2, Fabric] First painting in json *crash* #77

Closed TheSnowyChickens closed 1 year ago

TheSnowyChickens commented 1 year ago

Hello, I had a time with working custom paintings, but now I am hardstuck.

I get a crash with the first entry in the paintings.json, everytime I start MC and even If I remove the issued painting, I get a new crash with again the first entry.

grafik

I really have no idea what I am doing wrong, all the files are the same, all the names are the same and the files in the "paintings" folder in the minecraft instance folder are the same.

Resourcepack: example_resourcepack.zip (and yes, some pictures are from "DarkPaintings" mod, but with your mod and this way to install pictures, I save me 2 more mods in the pack later (atm I only use a tiny test pack))

Crash Report: crash-2022-09-05_20.12.51-client.txt

Logs: latest.log

MC: 1.19.2 P++: 10.2.0.0 Transparent: 1.7.1 Fabric: 0.14.9


Oh and, I can't join a server, because:

grafik

Pls help me. xD

AbsolemJackdaw commented 1 year ago

installing darkpaintings is 100% compatible with paintings++ and easier to use then putting them in a resourcepack. please do use darkhax's mod instead of extracting the paintings out of it !

if you need to join a server, the painting registry between client and server needs to match. the servers you join need to have the same paintings installed.

all your paintigns seem to load fine, or so says the log at least.

what made you determine following statement ?

I get a crash with the first entry in the paintings.json,

currently investigating

TheSnowyChickens commented 1 year ago

I had another picture in the first slot of the json, because it crashed I removed it and now the second (now first in the list) picture crash the game.

AbsolemJackdaw commented 1 year ago

image

this is why it is better to just use plug and play ...

you have a double entry. duplicate names aren't allowed.

TheSnowyChickens commented 1 year ago

oh xD

TheSnowyChickens commented 1 year ago

can you maybe add something to the crash that say something like "a double entry detected" ?

AbsolemJackdaw commented 1 year ago

you mean this ?

Caused by: java.lang.RuntimeException: Attempted to register ID ResourceKey[minecraft:painting_variant / paintings:dp_afternoon_volcano] at different raw IDs (-1, 136)! If you're trying to override an item, use .set(), not .register()!

AbsolemJackdaw commented 1 year ago

minecraft throws the error for you, I dont have to :P

TheSnowyChickens commented 1 year ago

Okay. :D

So, first problem solved.

AbsolemJackdaw commented 1 year ago

removing the double whale entry allowed me to start up the game.

if you got other issues please let me know !

if everything is solved, feel free to close the issue

also, use darkhax's mod :D the mod is a small one and does not add to the load you are trying to save your cpu from :)

TheSnowyChickens commented 1 year ago

Quick to the server thing: as I had the running version and I pasted the download link to the server properties, MC, after downloading, issued me the resourcepack on server side. Could this be the same issue with the double id's ? (or spelling issues)

This: grafik

AbsolemJackdaw commented 1 year ago

I'm not sure what you are explaining, but if the server has the correct, working resourcepack, and makes you download it, then it should work.

I am not aware of duplicates made by having the pack and you downloading the same pack from the server, but if the client ends up with two packs that add the same paintings, then you may have the same crash related to duplicate entries.

The crash you showed me however, was for painting entries missing

AbsolemJackdaw commented 1 year ago

my knowledge doesnt reach that far, but if the download failed, the server may have detected you already had the pack.

give the server the working pack, and the client a working pack, and let me know ! I'm going to end up learning something today too :D

TheSnowyChickens commented 1 year ago

Okay, after my League round I'm patching everything and let you know.

Thanks already.

I close the issue, I think we can still write after closing it.

TheSnowyChickens commented 1 year ago

now I broke everything. grafik

I removed the double "whale_dream", but I still can't start the game. :(

The few custom "ai_" pictures are very large (1024x1024 and more (but it's fine with the 16 row)), how large can a picture be ?

AbsolemJackdaw commented 1 year ago

the limit of the picture size is determined by your hardware

try a bigger wall ?

TheSnowyChickens commented 1 year ago

the wall is not the problem, your tiny 16x16 pictures are not loaded². (the resourcepack broke it)

GPU and CPU are not problem.

TheSnowyChickens commented 1 year ago

I am very sure it's again a tiny tiny tiny issue from my side, but after hours of trying I lost the overview.

I deleted the resourcepack string out of the options.txt, but I can't start the game.

AbsolemJackdaw commented 1 year ago

you aren't putting anything in the painting.json file in the painting folder right? only custom stuff in a resourcepack ?

AbsolemJackdaw commented 1 year ago

https://discord.gg/8MEdFZh

lets talk this over on my channel

AbsolemJackdaw commented 1 year ago

Fix found : the pack needs to be added to the resourcepack folder before the game starts, or the game needs to be restarted after dragging an d dropping the pack in the resourcepack gui.

TheSnowyChickens commented 1 year ago

Good job my hero.