search

AbsolemJackdaw / Paintings--

GNU General Public License v3.0
15 stars 13 forks source link

Enhancements to Pack Detection #80

Closed JTK222 closed 1 year ago

JTK222 commented 2 years ago

This PR is not finished yet, I still have to add a few more features. paintings json has to be in the root of a resource pack and called paintings++.json

AbsolemJackdaw commented 2 years ago

can it check for either paintings.json and paintings++.json ? that would allow backward compatibility with old packs

JTK222 commented 2 years ago

Sure, can add that. Would suggest dropping paintings.json with 1.20 though, it's risky enough to have a json in the root of resource packs, so it's definitely best to have the name as specific as possible.

JTK222 commented 1 year ago

but.. but it was untested 👀

AbsolemJackdaw commented 1 year ago

oh shit

AbsolemJackdaw commented 1 year ago

I reverted it you can continue to work on the branch

AbsolemJackdaw commented 1 year ago

let me see if i can reopen this