search

AbsolemJackdaw / Paintings--

GNU General Public License v3.0
14 stars 12 forks source link

Port to 1.19.4 #89

Closed Trikzon closed 11 months ago

Trikzon commented 1 year ago

The 1.19.3 PR does not work on 1.19.4, so I also ported Paintings++ to 1.19.4.

Only the method renderButton had to be changed to renderWidget.

In 1.19.4 Mojang also added painting variants to the creative tabs, so I added some code so that when placing these variants the Paintings++ gui does not pop up because the user clearly wants that specific painting.

image

Finally, I looked into possibly adding Paintings++ paintings to the creative menu. It seems like the only thing stopping that from happening already is that Paintings++ paintings aren't in the placeable painting variant tag. I don't know if it's easy to add entries to a tag at runtime, and I think the result would just be overwhelming the user with painting items in that creative tab so I decided to not look into it further. But if you or someone else is interested, that's where I'd look first.

Trikzon commented 1 year ago

This PR is done, but I made it a draft because I'm not sure what branch to have it PR into.

strikerrocker commented 11 months ago

A seperate branch is now created for 1.19.4. Can you rebase the commit onto that?