search

AbsolemJackdaw / PublicGuiAnnouncement

Creative Commons Zero v1.0 Universal
8 stars 8 forks source link

Add UtilitiX #25

Closed MelanX closed 1 year ago

MelanX commented 1 year ago

I made a seperate folder just for "melanx" because I wanted to add other mods, too. I don't know if I still want to add them during this month, so I keep it up to you if I should remove this sub-folder or not.

Trikzon commented 1 year ago

I don't think there is really a clear folder structure defined anywhere. Personally for my PRs adding support to mods, I made a subfolder for each author, so I think having a melanx folder even with just one mod is fine.

Trikzon commented 1 year ago

Should the textures be 256x256? My 2nd PR used 255x255 images (which I thought was strange) because you wiki says to make them 255x255.

AbsolemJackdaw commented 1 year ago

doesnt really matter. one pixel difference wont stretch them too much. i think my editing software starts at 1 insead of 0 so it shows 255x textures instead of 256 lol

Trikzon commented 1 year ago

Fair enough. I might make another PR in a few days for support for a few more mods, so I'll fix them to 256x256 anyways in that if I do.

MelanX commented 1 year ago

It’s just the texture, not 256x256, and I provided the "texSize" for that image. Or did I another thing wrong?

AbsolemJackdaw commented 1 year ago

on second review everything is indeed done correctly. must have looked at it cross eyed two days ago ...