search

AbsolemJackdaw / Rpg-Inventory-2016

3 stars 0 forks source link

[1.12.2] Conflict with Living Enchantment's Tool Effectiveness. #14

Open SonicX8000 opened 5 years ago

SonicX8000 commented 5 years ago

Minecraft: 1.12.2 Forge: 14.23.5.2807

Mods: 4 living_enchantment-2.6.0 rpginventory-1.12-5.3.0.0 subcommonlib-sublib-1.12.2-1.2.0.4 theoneprobe-1.12-1.4.24

Living Enchantment adds an enchantment that increases the effectiveness of your tool as it gains levels. However for some odd reason it's Tool Effectiveness no longer works if I have "RPG Inventory" installed.

Using 'The One Probe' which shows a progress bar while harvesting a block... these are the results I get after harvesting the block for half a second.

Tools: Diamond Pickaxe | Diamond Pickaxe + Living Enchantment at Lv 50.

Living Enchantment's Tool Effectiveness at 0.05

If RPG Inventory is installed... Cobblestone 13% | 13%

Block of Iron 5% | 5%

If RPG Inventory isn't installed... Cobblestone 13% | 46%

Block of Iron 5% | 18%

===== I wasn't wearing any of the items to increase my Mining Speed while performing the test.

Refer'd Issue: https://minecraft.curseforge.com/projects/living-enchantment/issues/3

SonicX8000 commented 5 years ago

Looking at the source code on github ... apparently the conflict is fixed when the "getOriginalSpeed" was replaced with "getNewSpeed". It's just that it hasn't been released yet. Not trying to rush but figure I give it a mention.

AbsolemJackdaw commented 5 years ago

Ah yes thanks for the heads up. Im slowly getting back into the scene, give it a few days :)

SonicX8000 commented 5 years ago

Aye, welcome back.