search

AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
79 stars 18 forks source link

Small Nits #297

Closed Kayanski closed 10 months ago

Kayanski commented 10 months ago

Added std error to TxHandler::Error

cloudflare-workers-and-pages[bot] commented 10 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52fab63
Status:🚫  Build failed.

View logs

CyberHoward commented 10 months ago

Not a huge fan of the START / END

codecov[bot] commented 10 months ago

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (c087e2f) 65.6% compared to head (904b643) 65.5%. Report is 1 commits behind head on main.

:exclamation: Current head 904b643 differs from pull request most recent head 4359849. Consider uploading reports for the commit 4359849 to get more accurate results

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [...-orch-core/src/environment/cosmwasm\_environment.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9lbnZpcm9ubWVudC9jb3Ntd2FzbV9lbnZpcm9ubWVudC5ycw==) | `54.5% <ø> (ø)` | | | [...ges/cw-orch-core/src/contract/contract\_instance.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9jb250cmFjdC9jb250cmFjdF9pbnN0YW5jZS5ycw==) | `78.6% <59.6%> (-11.5%)` | :arrow_down: |
Buckram123 commented 10 months ago

Would agree with Howard about [START] and [END]. And would it be possible to align first block? It's currently hard to process(with my eyes)

[2024-01-09T09:46:28Z INFO              Local] Writing daemon state JSON file: "/root/.cw-orchestrator/state_local.json"
[2024-01-09T09:46:28Z INFO              Local] Interacting with testing using address: juno16g2rahf5846rxzp3fwlswy08fz8ccuwk03k57y
[2024-01-09T09:46:28Z INFO           Contract] [local:counter][Upload][START]
[2024-01-09T09:46:28Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:38Z INFO        Transaction] Uploading done: "B84AEF9F3CAC18060036E66F71AC8030EBEA21BC17CDF5A10464CFA4EC036779"
[2024-01-09T09:46:38Z INFO           Contract] [local:counter][Upload][END] code_id 5
[2024-01-09T09:46:38Z INFO           Contract] [local:counter][Instantiate][START]
[2024-01-09T09:46:38Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:48Z INFO        Transaction] Instantiation done: "8B2E2894AAB63E35CF2D21CED65F57B701EF53820C0C87D1F581EBB2B5A865E4"
[2024-01-09T09:46:48Z INFO           Contract] [local:counter][Instantiate][END] juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4
[2024-01-09T09:46:48Z INFO           Contract] [local:counter][Execute][juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4][START] increment
[2024-01-09T09:46:48Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:58Z INFO        Transaction] Execution done: "F6190D05E7A4C8EC636537F5114A789995CFAAB473FB0ADAFF0ACD17408098B0"
[2024-01-09T09:46:58Z INFO           Contract] [local:counter][Execute][juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4][END] increment

Also not sure if awaiting TX inclusion should be marked with Retry