search

AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
79 stars 18 forks source link

Nicolas/orc 67 no way to set hd index #306

Closed Kayanski closed 9 months ago

Kayanski commented 10 months ago

This PR aims at introducing index modifications on the sender object. Depends on https://github.com/AbstractSDK/cw-orchestrator/pull/305

cloudflare-workers-and-pages[bot] commented 10 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71f4614
Status:⚡️  Build in progress...

View logs

Kayanski commented 9 months ago

Is there a reason why you need this?

The hd index is like a derivation sequence right? So you can create multiple wallets from the same private key?

You can create multiple wallets from the same mnemonic yes ! It was a request from @Buckram123 Something to do with Starship I think.

Buckram123 commented 9 months ago

Is there a reason why you need this?

For example this signer: https://github.com/cosmology-tech/starship/blob/5dcc918dc7d87a713bcde684293f5cdf5df1c63c/charts/devnet/scripts/neutron/create-neutron-genesis.sh#L45-L47

I have mnemonic, but have no way to sign it using cw-orch

CyberHoward commented 9 months ago

LGTM!

codecov[bot] commented 9 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a990cbe) 66.2% compared to head (344acd9) 66.2%. Report is 1 commits behind head on main.

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [cw-orch-daemon/src/sync/builder.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3N5bmMvYnVpbGRlci5ycw==) | `70.7% <100.0%> (+3.1%)` | :arrow_up: | | [cw-orch-daemon/src/builder.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL2J1aWxkZXIucnM=) | `63.4% <0.0%> (-4.4%)` | :arrow_down: | | [cw-orch-daemon/src/sender.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3NlbmRlci5ycw==) | `61.7% <50.0%> (-0.8%)` | :arrow_down: |