search

AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
76 stars 18 forks source link

Fixed mock app with bech32 enforcement #312

Closed Kayanski closed 7 months ago

Kayanski commented 8 months ago

TODO : Updated mock to pass tests with the same API (accepting sender as a valid address) --> Modify call as as well to present a better api for users ?

Depends on https://github.com/AbstractSDK/cw-orchestrator/pull/303

cloudflare-pages[bot] commented 8 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aaa4a0b
Status:🚫  Build failed.

View logs

CyberHoward commented 7 months ago

A broader question we could ask here is: do we want to enforce use of bech32 or do we want it to be optional?

If we want it to be optional we should make that clear with the type system. If we want to enforce it we should get rid of most impl Into<String> where an address is expected.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9813829) 66.1% compared to head (aaa4a0b) 66.1%. Report is 2 commits behind head on main.

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [contracts/mock\_contract/src/msg\_tests.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL21vY2tfY29udHJhY3Qvc3JjL21zZ190ZXN0cy5ycw==) | `94.8% <100.0%> (ø)` | | | [cw-orch-daemon/src/log.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL2xvZy5ycw==) | `61.5% <100.0%> (ø)` | | | [cw-orch/src/snapshots.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC9zcmMvc25hcHNob3RzLnJz) | `100.0% <100.0%> (ø)` | | | [cw-orch/src/osmosis\_test\_tube/core.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC9zcmMvb3Ntb3Npc190ZXN0X3R1YmUvY29yZS5ycw==) | `66.5% <0.0%> (ø)` | | | [packages/cw-orch-mock/src/core.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1tb2NrL3NyYy9jb3JlLnJz) | `90.6% <95.4%> (+0.1%)` | :arrow_up: | | [packages/cw-orch-core/src/environment/mut\_env.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9lbnZpcm9ubWVudC9tdXRfZW52LnJz) | `0.0% <0.0%> (ø)` | |