AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
79 stars 18 forks source link

Use hexbinary as checksum #328

Closed Buckram123 closed 8 months ago

Buckram123 commented 8 months ago

This PR aims to return cosmwasm_std::HexBinary instead of hex encoded String, for checksums

cloudflare-workers-and-pages[bot] commented 8 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f06662
Status: βœ…  Deploy successful!
Preview URL: https://4ab33556.cw-orchestrator.pages.dev
Branch Preview URL: https://fix-checksum-should-not-be-s.cw-orchestrator.pages.dev

View logs

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (61369ea) 65.4% compared to head (61cfbcb) 65.4%.

:exclamation: Current head 61cfbcb differs from pull request most recent head 8f06662. Consider uploading reports for the commit 8f06662 to get more accurate results

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Ξ” | | |---|---|---| | [packages/cw-orch-core/src/contract/paths.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9jb250cmFjdC9wYXRocy5ycw==) | `70.0% <100.0%> (+0.7%)` | :arrow_up: | | [...ages/cw-orch-core/src/environment/queriers/wasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9lbnZpcm9ubWVudC9xdWVyaWVycy93YXNtLnJz) | `100.0% <100.0%> (ΓΈ)` | | | [packages/cw-orch-mock/src/queriers/wasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1tb2NrL3NyYy9xdWVyaWVycy93YXNtLnJz) | `79.7% <100.0%> (+0.4%)` | :arrow_up: | | [cw-orch-daemon/src/queriers/cosmwasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3F1ZXJpZXJzL2Nvc213YXNtLnJz) | `47.4% <75.0%> (-0.3%)` | :arrow_down: | | [cw-orch/src/osmosis\_test\_tube/queriers/wasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC9zcmMvb3Ntb3Npc190ZXN0X3R1YmUvcXVlcmllcnMvd2FzbS5ycw==) | `53.3% <83.3%> (+0.3%)` | :arrow_up: |
Buckram123 commented 8 months ago

@CyberHoward just noticed I forgot to update docs so doc tests are failing πŸ‘€

CyberHoward commented 8 months ago

@CyberHoward just noticed I forgot to update docs so doc tests are failing πŸ‘€

Can you push a fix to a new pr?