search

AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
76 stars 18 forks source link

Rollkit #353

Closed Kayanski closed 5 months ago

Kayanski commented 5 months ago

This PR aims at integrating rollkit inside cw-orch.

For this integration, I used :

I modified :

cloudflare-pages[bot] commented 5 months ago

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9563db
Status: ✅  Deploy successful!
Preview URL: https://fa38e850.cw-orchestrator.pages.dev
Branch Preview URL: https://rollkit.cw-orchestrator.pages.dev

View logs

CyberHoward commented 5 months ago

I modified :

  • In init.sh script, I replaced all occurences of stake by uwasm to be able to pay for gas with the created mnemonic/address
  • I used the generated genesis mnemonic of wasmd as LOCAL_MNEMONIC Were these modifications upstreamed?
Kayanski commented 5 months ago

I modified :

  • In init.sh script, I replaced all occurences of stake by uwasm to be able to pay for gas with the created mnemonic/address
  • I used the generated genesis mnemonic of wasmd as LOCAL_MNEMONIC Were these modifications upstreamed?

Not sure what you're saying here. The init.sh oart yes, the local mnemonic part is something the user should do

CyberHoward commented 5 months ago

Then that should prefably be documented as well in the doc that you added (how to get the local mnemonic if following the tutorial)

adairrr commented 5 months ago

Is ROLLKIT_1 going to be the best name for this network configuration given that it's always run locally?

Should we include details on connecting to a hosted rollup?

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.7%. Comparing base (b8ceade) to head (f9563db). Report is 2 commits behind head on main.

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/353?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [packages/cw-orch-networks/src/networks/mod.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/353?src=pr&el=tree&filepath=packages%2Fcw-orch-networks%2Fsrc%2Fnetworks%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1uZXR3b3Jrcy9zcmMvbmV0d29ya3MvbW9kLnJz) | `0.0% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/353/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK)
CyberHoward commented 5 months ago

Is ROLLKIT_1 going to be the best name for this network configuration given that it's always run locally?

Should we include details on connecting to a hosted rollup?

Our documentation should follow their documentation imo. Otherwise we need to document too much overlapping stuff and if they are not following the rollkit docs then they probably know what they are doing and they can figure out stuff themselves, like a hosted rollup.