search

AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
76 stars 18 forks source link

Loosen trait bounds in cw-orch-core #361

Closed Kayanski closed 5 months ago

Kayanski commented 5 months ago

This Pr aims at loosening some trait bounds in cw-orch-core because theyr are un-necessary

cloudflare-pages[bot] commented 5 months ago

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: be82090
Status: ✅  Deploy successful!
Preview URL: https://d86b11d3.cw-orchestrator.pages.dev
Branch Preview URL: https://nicolas-orc-104-trait-bounds.cw-orchestrator.pages.dev

View logs

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.7%. Comparing base (ff1e75d) to head (be82090). Report is 3 commits behind head on main.

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [contracts/counter/src/interface.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=contracts%2Fcounter%2Fsrc%2Finterface.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL2NvdW50ZXIvc3JjL2ludGVyZmFjZS5ycw==) | `42.1% <ø> (ø)` | | | [contracts/mock\_contract/src/lib.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=contracts%2Fmock_contract%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL21vY2tfY29udHJhY3Qvc3JjL2xpYi5ycw==) | `97.9% <ø> (ø)` | | | [contracts/mock\_contract/src/msg\_tests.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=contracts%2Fmock_contract%2Fsrc%2Fmsg_tests.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL21vY2tfY29udHJhY3Qvc3JjL21zZ190ZXN0cy5ycw==) | `94.7% <ø> (ø)` | | | [contracts/mock\_contract\_u64/src/lib.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=contracts%2Fmock_contract_u64%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL21vY2tfY29udHJhY3RfdTY0L3NyYy9saWIucnM=) | `83.3% <ø> (ø)` | | | [cw-orch-daemon/src/channel.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fchannel.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL2NoYW5uZWwucnM=) | `82.9% <100.0%> (ø)` | | | [cw-orch/src/snapshots.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=cw-orch%2Fsrc%2Fsnapshots.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC9zcmMvc25hcHNob3RzLnJz) | `97.5% <ø> (ø)` | | | [packages/cw-orch-contract-derive/src/lib.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=packages%2Fcw-orch-contract-derive%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb250cmFjdC1kZXJpdmUvc3JjL2xpYi5ycw==) | `93.0% <100.0%> (ø)` | | | [packages/cw-orch-core/src/contract/deploy.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=packages%2Fcw-orch-core%2Fsrc%2Fcontract%2Fdeploy.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9jb250cmFjdC9kZXBsb3kucnM=) | `0.0% <ø> (ø)` | | | [...ages/cw-orch-core/src/contract/interface\_traits.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=packages%2Fcw-orch-core%2Fsrc%2Fcontract%2Finterface_traits.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9jb250cmFjdC9pbnRlcmZhY2VfdHJhaXRzLnJz) | `75.9% <ø> (ø)` | | | [packages/cw-orch-fns-derive/src/execute\_fns.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree&filepath=packages%2Fcw-orch-fns-derive%2Fsrc%2Fexecute_fns.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1mbnMtZGVyaXZlL3NyYy9leGVjdXRlX2Zucy5ycw==) | `99.2% <100.0%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/361?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | |
Kayanski commented 5 months ago

amazing, is this a breaking change to core?

I'm not sure how to test that :/ Because we don't have abstract on that version, so it won't be all covering

Kayanski commented 5 months ago

amazing, is this a breaking change to core?

It shouldn't be, but I'm not sure there were not changes in the main branch that were breaking

CyberHoward commented 5 months ago

amazing, is this a breaking change to core?

It shouldn't be, but I'm not sure there were not changes in the main branch that were breaking

This is important for you to keep track of. You can go through commits on main and see if any of them are PRs that you expect to be breaking and look into them.