search

AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
76 stars 18 forks source link

Nicolas/orc 103 contractwrapper uploadable does not require self #376

Closed Kayanski closed 4 months ago

Kayanski commented 4 months ago

This PR aims at removing the self parameter from the Uploadable Trait.

Amended the localhash querier function :

  1. Removed the generic implementation because the implementation can't be generic anymore.
  2. Amended the trait to have the Chain parameter not be a generic on function but a generic on the trait. It forces us to add the StateInterface generic on the querier object
cloudflare-pages[bot] commented 4 months ago

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2ef2e31
Status: ✅  Deploy successful!
Preview URL: https://cc48ded3.cw-orchestrator.pages.dev
Branch Preview URL: https://nicolas-orc-103-contractwrap.cw-orchestrator.pages.dev

View logs

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.46729% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 63.9%. Comparing base (4f272cb) to head (2ef2e31).

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [contracts/counter/src/interface.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=contracts%2Fcounter%2Fsrc%2Finterface.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL2NvdW50ZXIvc3JjL2ludGVyZmFjZS5ycw==) | `42.1% <100.0%> (ø)` | | | [contracts/mock\_contract/src/lib.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=contracts%2Fmock_contract%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL21vY2tfY29udHJhY3Qvc3JjL2xpYi5ycw==) | `97.8% <100.0%> (-0.1%)` | :arrow_down: | | [contracts/mock\_contract/src/msg\_tests.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=contracts%2Fmock_contract%2Fsrc%2Fmsg_tests.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL21vY2tfY29udHJhY3Qvc3JjL21zZ190ZXN0cy5ycw==) | `94.7% <100.0%> (ø)` | | | [cw-orch-daemon/src/builder.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fbuilder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL2J1aWxkZXIucnM=) | `62.9% <ø> (ø)` | | | [cw-orch-daemon/src/core.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fcore.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL2NvcmUucnM=) | `58.5% <100.0%> (ø)` | | | [cw-orch-daemon/src/live\_mock.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Flive_mock.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL2xpdmVfbW9jay5ycw==) | `51.2% <ø> (ø)` | | | [cw-orch-daemon/src/queriers/cosmwasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fqueriers%2Fcosmwasm.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3F1ZXJpZXJzL2Nvc213YXNtLnJz) | `49.5% <100.0%> (+2.0%)` | :arrow_up: | | [cw-orch-daemon/src/state.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fstate.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3N0YXRlLnJz) | `88.9% <ø> (ø)` | | | [cw-orch-daemon/src/sync/builder.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fsync%2Fbuilder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3N5bmMvYnVpbGRlci5ycw==) | `86.8% <ø> (ø)` | | | [cw-orch-daemon/src/sync/core.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fsync%2Fcore.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3N5bmMvY29yZS5ycw==) | `69.5% <100.0%> (ø)` | | | ... and [16 more](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/376/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK)