Closed Kayanski closed 2 months ago
Latest commit: |
4bc002d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://af908b1a.cw-orchestrator.pages.dev |
Branch Preview URL: | https://nicolas-orc-126-daemon-shoul.cw-orchestrator.pages.dev |
Attention: Patch coverage is 63.43826%
with 151 lines
in your changes missing coverage. Please review.
Project coverage is 54.9%. Comparing base (
99b6deb
) to head (4bc002d
).
Closed in favor of #438
This PR aims at separating the daemon and the sender to be able to compose with senders and queriers.
I removed the Arc wrapper around the Sender because the
SenderTrait
trait needs theset_options
method to take a mutable reference, which arc can't do because it can't mutate the underlying object.When using a Mutex to allow for mutability, the async methods of the trait error because of a Send bound that is not available.
We will need to think about that, if we want the Sender to be copiable