Closed Buckram123 closed 2 months ago
Latest commit: |
9215edd
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ecec2f8a.cw-orchestrator.pages.dev |
Branch Preview URL: | https://misha-orc-127-daemon-rebuild.cw-orchestrator.pages.dev |
Attention: Patch coverage is 93.33333%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 65.1%. Comparing base (
41fc930
) to head (9215edd
).
Very nice ! We will need to support updating the daemon state as well when rebuilding, but that's another task.
What do you mean by this?
Very nice ! We will need to support updating the daemon state as well when rebuilding, but that's another task.
What do you mean by this?
Here, when the state of the daemon is updated (grpc channel for instance, if a same daemon is used for another chain), the sender channel is not updated which leads to issues if you're changing the chain.
https://github.com/AbstractSDK/cw-orchestrator/blob/main/cw-orch-daemon/src/builder.rs#L110
This is addressed in https://github.com/AbstractSDK/cw-orchestrator/pull/326
hd_index impacts private key meaning if it's provided inside
SenderOptions
new Sender should be created from scratch Closes ORC-127, Closes ORC-125