search

AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
75 stars 17 forks source link

Nicolas/orc 144 rename the get chain helper #423

Closed Kayanski closed 1 month ago

Kayanski commented 2 months ago

This PR aims at adding an environment method on contracts that replaces the current get_chain. We also add an Environment trait that allows any structure to be built around an environment

This is not breaking ? Should we make the change at the Cw-Orch-Core level and make that breaking ?

Checklist

cloudflare-pages[bot] commented 2 months ago

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: f861c0b
Status: ✅  Deploy successful!
Preview URL: https://6f43365c.cw-orchestrator.pages.dev
Branch Preview URL: https://nicolas-orc-144-rename-the-g.cw-orchestrator.pages.dev

View logs

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.3%. Comparing base (9327e5e) to head (f861c0b). Report is 3 commits behind head on main.

Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [cw-orch-daemon/src/queriers/cosmwasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fqueriers%2Fcosmwasm.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3F1ZXJpZXJzL2Nvc213YXNtLnJz) | `51.5% <100.0%> (ø)` | | | [packages/interchain/interchain-core/src/env.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?src=pr&el=tree&filepath=packages%2Finterchain%2Finterchain-core%2Fsrc%2Fenv.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvaW50ZXJjaGFpbi9pbnRlcmNoYWluLWNvcmUvc3JjL2Vudi5ycw==) | `72.5% <100.0%> (ø)` | | | [contracts/counter/src/interface.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?src=pr&el=tree&filepath=contracts%2Fcounter%2Fsrc%2Finterface.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL2NvdW50ZXIvc3JjL2ludGVyZmFjZS5ycw==) | `42.1% <0.0%> (ø)` | | | [packages/cw-orch-core/src/contract/deploy.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?src=pr&el=tree&filepath=packages%2Fcw-orch-core%2Fsrc%2Fcontract%2Fdeploy.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9jb250cmFjdC9kZXBsb3kucnM=) | `0.0% <0.0%> (ø)` | | | [...es/interchain/interchain-daemon/src/ibc\_tracker.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?src=pr&el=tree&filepath=packages%2Finterchain%2Finterchain-daemon%2Fsrc%2Fibc_tracker.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvaW50ZXJjaGFpbi9pbnRlcmNoYWluLWRhZW1vbi9zcmMvaWJjX3RyYWNrZXIucnM=) | `0.0% <0.0%> (ø)` | | | [...ges/cw-orch-core/src/contract/contract\_instance.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?src=pr&el=tree&filepath=packages%2Fcw-orch-core%2Fsrc%2Fcontract%2Fcontract_instance.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9jb250cmFjdC9jb250cmFjdF9pbnN0YW5jZS5ycw==) | `80.7% <33.3%> (-1.1%)` | :arrow_down: | | [...ages/cw-orch-core/src/contract/interface\_traits.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423?src=pr&el=tree&filepath=packages%2Fcw-orch-core%2Fsrc%2Fcontract%2Finterface_traits.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9jb250cmFjdC9pbnRlcmZhY2VfdHJhaXRzLnJz) | `75.1% <80.0%> (-1.4%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/423/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK)
Buckram123 commented 2 months ago

This is not breaking ? Should we make the change at the Cw-Orch-Core level and make that breaking ?

We can deprecate .get_chain() method for the patch and remove from cw-orch-core in the next version. What do you think?

Kayanski commented 2 months ago

This is not breaking ? Should we make the change at the Cw-Orch-Core level and make that breaking ?

We can deprecate .get_chain() method for the patch and remove from cw-orch-core in the next version. What do you think?

Yes good idea, what about the Environment trait ? We can't use it and make this change non-breaking